Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Chrome 56 #1325

Closed
wants to merge 4 commits into from
Closed

Added support for Chrome 56 #1325

wants to merge 4 commits into from

Conversation

nebnoslen
Copy link
Contributor

No description provided.

@nebnoslen
Copy link
Contributor Author

Apologies, my first time commiting code in GitHub.
Please review and use only commit "Merge pull request #1 from bennelson1234/addChromeDetection".
The commits "Update browser.js", "Add Chrome 56" and "Added Chrome 56" can be ignored as they have typos and I don't know how to un-commit them.

@bcoles
Copy link
Collaborator

bcoles commented Dec 2, 2016

Hi @bennelson1234

Thanks for taking the time to do this!

Unfortunately your pull request is kind of a mess. Could you resubmit the pull request with only the required changes (without reformatting/indenting existing code). Thanks.

I would fix it myself by frankly I'm drunk and couldn't be bothered. It's likely easier/faster to submit a new PR.

Here's an example of adding support for a new browser version, albeit for Firefox: e95ef8f

@nebnoslen
Copy link
Contributor Author

I'll fix all this and get it right :-)

@nebnoslen nebnoslen closed this Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants